-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git application #184
Git application #184
Conversation
78b27b8
to
575f181
Compare
9786f7e
to
c47976d
Compare
8230872
to
74d4647
Compare
61e6954
to
6fea057
Compare
Great job! But let's fix a couple of issues:
|
|
|
|
|
"Error handling if ssh key isn't added should be better. It will be a usual mistake. Need to ask the user to add ssh key into git server explicitly" |
@nmanovic |
@nmanovic |
@nmanovic |
It isn't during building. It is when a user try to push something into a repository for which the user doesn't add generated ssh key. It will get some error that the repository cannot be cloned with a lot of extra stuff. I remember that it isn't so easy to understand why a repository cannot be cloned. Let's say that "Probably SSH key was not added to your profile for the cloned repository. Please add the key below and try again". |
Why do we need it inside repository? Is it a temporary file for internal purpose? |
Indeed the task is very important. It is really good feature. I need it to be sure that latest tasks are synchronized and it will be inconvenient to click each time on a task to understand its status. There are several ways to implement that:
|
Does ssh key is regenerated each time when you re-build CVAT? If it is so need to fix that. It should be generated once as django security key. It is really a pain to add a new key each time. |
@nmanovic |
Is it possible to incorporate the information into git commit message? Why do we need a separate file for that? |
f3f1bc8
to
933cbbb
Compare
@nmanovic |
Resolved #126